[webkit-reviews] review granted: [Bug 182716] Unify UserAgent into WebCore/platform. : [Attachment 333644] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 12 17:20:55 PST 2018


Michael Catanzaro <mcatanzaro at igalia.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 182716: Unify UserAgent into WebCore/platform.
https://bugs.webkit.org/show_bug.cgi?id=182716

Attachment 333644: Patch

https://bugs.webkit.org/attachment.cgi?id=333644&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 333644
  --> https://bugs.webkit.org/attachment.cgi?id=333644
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333644&action=review

Nice, thanks.

> Source/WebCore/platform/UserAgent.h:-32
> -#if PLATFORM(COCOA)
> -// FIXME: Remove Source/WebCore/page/cocoa/UserAgent.h
> -#include_next "UserAgent.h"
> -#else

Wow, I forgot that #include_next existed. That was awful.


More information about the webkit-reviews mailing list