[webkit-reviews] review granted: [Bug 193055] .ycm_extra_conf.py should handle XXXInlines.h : [Attachment 358135] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 31 05:50:05 PST 2018
Carlos Garcia Campos <cgarcia at igalia.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 193055: .ycm_extra_conf.py should handle XXXInlines.h
https://bugs.webkit.org/show_bug.cgi?id=193055
Attachment 358135: Patch
https://bugs.webkit.org/attachment.cgi?id=358135&action=review
--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 358135
--> https://bugs.webkit.org/attachment.cgi?id=358135
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=358135&action=review
> Tools/gtk/ycm_extra_conf.py:90
> + else:
Does this work? this else: is not correctly indented. It can be removed,
though, since previous line is a return.
More information about the webkit-reviews
mailing list