[webkit-reviews] review requested: [Bug 105023] Web Inspector: Change the InspectorOverlay to use native rather than canvas : [Attachment 358151] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has asked  for review:
Bug 105023: Web Inspector: Change the InspectorOverlay to use native rather
than canvas
https://bugs.webkit.org/show_bug.cgi?id=105023

Attachment 358151: Patch

https://bugs.webkit.org/attachment.cgi?id=358151&action=review




--- Comment #9 from Devin Rousso <drousso at apple.com> ---
Created attachment 358151

  --> https://bugs.webkit.org/attachment.cgi?id=358151&action=review

Patch

Since we no longer need any of the OverlayTypes protocol objects, it doesn't
make sense to keep them around just for tests, especially since the actual code
path wouldn't use the types either.  I\'m not set on the idea of using a base64
encoded image of the contents of the overlay as a means of testing the
correctness of the overlay, but I figured that it was a step in the right
direction.  This would also allow us to test interactions a bit more (e.g.
making sure that things don\'t overlap unless we want them to), as well as more
general overlay things (e.g. rulers).  Feedback welcome :)