[webkit-reviews] review requested: [Bug 193016] Leak of CMSampleBuffer (752 bytes) in com.apple.WebKit.WebContent running WebKit layout tests : [Attachment 358146] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 29 21:07:35 PST 2018


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 193016: Leak of CMSampleBuffer (752 bytes) in com.apple.WebKit.WebContent
running WebKit layout tests
https://bugs.webkit.org/show_bug.cgi?id=193016

Attachment 358146: Patch v1

https://bugs.webkit.org/attachment.cgi?id=358146&action=review




--- Comment #12 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Created attachment 358146

  --> https://bugs.webkit.org/attachment.cgi?id=358146&action=review

Patch v1

- Removed RetainPtr<>::handleCF() changes and went with static helper methods
per Dan's suggestion.
- Adding RetainPtr.cpp to TestWTFLibrary is now in patch for Bug 193056.


More information about the webkit-reviews mailing list