[webkit-reviews] review granted: [Bug 193050] [JSC] Identifier validity should be based on ID_Start / ID_Continue properties : [Attachment 358134] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 30 01:00:22 PST 2018
Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 193050: [JSC] Identifier validity should be based on ID_Start / ID_Continue
properties
https://bugs.webkit.org/show_bug.cgi?id=193050
Attachment 358134: Patch
https://bugs.webkit.org/attachment.cgi?id=358134&action=review
--- Comment #16 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 358134
--> https://bugs.webkit.org/attachment.cgi?id=358134
Patch
r=me. Before landing, please ensure that perf regression does not happen in
UChar path by adding some non latin characters in Octane jquery/closure and
ensure Lexer<UChar> is used at that time (instead of Lexer<LChar>.
More information about the webkit-reviews
mailing list