[webkit-reviews] review granted: [Bug 191976] [FreeType] Color emoji not properly supported : [Attachment 357679] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 191976: [FreeType] Color emoji not properly supported
https://bugs.webkit.org/show_bug.cgi?id=191976

Attachment 357679: Patch

https://bugs.webkit.org/attachment.cgi?id=357679&action=review




--- Comment #15 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 357679
  --> https://bugs.webkit.org/attachment.cgi?id=357679
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357679&action=review

Myles might want to review the cross-platform changes after the holidays, but
they look relatively straightforward so I don't think we need to delay.

> Source/WTF/wtf/unicode/CharacterNames.h:103
> +const UChar combiningEnclosingKeycap = 0x20E3;

This should be alphabetized, like the rest of the list.

> Source/WTF/wtf/unicode/CharacterNames.h:170
> +using WTF::Unicode::combiningEnclosingKeycap;

Ditto.

>> Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:67
>> +	    if (nextCharacter == 0xFE0F) {
> 
> Maybe it would be good to give a name to this constant instead of leaving
> magic numbers around in the middle of the function.

I think it's fine; it's not used anywhere else, and there's a comment to
explain it.