[webkit-reviews] review requested: [Bug 193048] [iOS] Pressing Tab key doesn't move to next cell with Google Sheets : [Attachment 358120] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 28 12:18:37 PST 2018


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 193048: [iOS] Pressing Tab key doesn't move to next cell with Google Sheets
https://bugs.webkit.org/show_bug.cgi?id=193048

Attachment 358120: Patch

https://bugs.webkit.org/attachment.cgi?id=358120&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Created attachment 358120

  --> https://bugs.webkit.org/attachment.cgi?id=358120&action=review

Patch

I suspect the reason we added these key commands was to work around an issue
where key events when pressing Tab or Shift + Tab inside a password field would
not be sent to WebKit as a result of UIKit decision to disallow the tab
character inside a password field for native apps. I will fix address the UIKit
issue in <rdar://problem/46972559>. For now, I did not include a test. I will
add a test in a follow up bug.


More information about the webkit-reviews mailing list