[webkit-reviews] review granted: [Bug 180373] Web Inspector: Crashes seen under Inspector::ScriptCallFrame::~ScriptCallFrame : [Attachment 357982] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 21 14:56:26 PST 2018
Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 180373: Web Inspector: Crashes seen under
Inspector::ScriptCallFrame::~ScriptCallFrame
https://bugs.webkit.org/show_bug.cgi?id=180373
Attachment 357982: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=357982&action=review
--- Comment #6 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 357982
--> https://bugs.webkit.org/attachment.cgi?id=357982
[PATCH] Proposed Fix
rs=me, I think it's "safer" to just not call `.get()`, but as you pointed out,
there's nothing really happening in the loop, so I guess it's fine. Hopefully
our future selves don't mess it up 😛
More information about the webkit-reviews
mailing list