[webkit-reviews] review granted: [Bug 192123] Web Inspector: Styles: editing focus lost when inspector is blurred : [Attachment 357981] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 21 15:00:53 PST 2018
Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 192123: Web Inspector: Styles: editing focus lost when inspector is blurred
https://bugs.webkit.org/show_bug.cgi?id=192123
Attachment 357981: Patch
https://bugs.webkit.org/attachment.cgi?id=357981&action=review
--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 357981
--> https://bugs.webkit.org/attachment.cgi?id=357981
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=357981&action=review
r=me, awesome!
> Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js:217
> + if (!document.hasFocus())
I think a "safer" approach may be to check that the active element is still
this element, meaning that we did a blur without moving the focus (e.g. the
entire window lost focus)
if (document.activeElement === this._element)
More information about the webkit-reviews
mailing list