[webkit-reviews] review granted: [Bug 192736] HTTPS Upgrade: Use full sqlite upgrade list : [Attachment 357727] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Vivek Seth <v_seth at apple.com>'s
request for review:
Bug 192736: HTTPS Upgrade: Use full sqlite upgrade list
https://bugs.webkit.org/show_bug.cgi?id=192736

Attachment 357727: Patch

https://bugs.webkit.org/attachment.cgi?id=357727&action=review




--- Comment #22 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 357727
  --> https://bugs.webkit.org/attachment.cgi?id=357727
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357727&action=review

r=me with suggestion.

> Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.cpp:68
> +	   ASSERT(isDatabaseOpen);

I think we should return early if !isDatabaseOpen in release so that
m_didSetupCompleteSuccessfully never gets set to true.