[webkit-reviews] review granted: [Bug 192619] [BigInt] Implement DFG/FTL typeof for BigInt : [Attachment 357114] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 192619: [BigInt] Implement DFG/FTL typeof for BigInt
https://bugs.webkit.org/show_bug.cgi?id=192619

Attachment 357114: Patch

https://bugs.webkit.org/attachment.cgi?id=357114&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 357114
  --> https://bugs.webkit.org/attachment.cgi?id=357114
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357114&action=review

r=me.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:14220
> +	   //	  } else if (is bigint) {

Do we think that bigints are going to be more or less common than symbol? 

Also, when we add a value representation for "small big ints" I would expect
symbols would be more common. Can we add a FIXME: here to switch the ordering
when that happens?

> Source/JavaScriptCore/jit/AssemblyHelpers.h:1658
> +	   //	  } else if (is bigint) {
> +	   //	      return bigint

Ditto