[webkit-reviews] review granted: [Bug 190047] [JSC] Optimize Object.keys by caching own keys results in StructureRareData : [Attachment 356953] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 190047: [JSC] Optimize Object.keys by caching own keys results in
StructureRareData
https://bugs.webkit.org/show_bug.cgi?id=190047

Attachment 356953: Patch

https://bugs.webkit.org/attachment.cgi?id=356953&action=review




--- Comment #12 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 356953
  --> https://bugs.webkit.org/attachment.cgi?id=356953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356953&action=review

r=me. Although, I agree with Saam that we should probably have a story for
collecting stale enumerations. Can you file a bug?

Maybe something like: clear on FullGC + Structure is only referenced via a
transition? Not sure how we would determine the latter though...

> Source/JavaScriptCore/runtime/StructureRareDataInlines.h:62
> +    return m_cachedOwnKeys.get();

Do we have an ASSERT(!compilationOrGCThread())?