[webkit-reviews] review denied: [Bug 191677] [JSC] Implement "well-formed JSON.stringify" proposal : [Attachment 355194] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 12 09:13:29 PST 2018


Darin Adler <darin at apple.com> has denied  review:
Bug 191677: [JSC] Implement "well-formed JSON.stringify" proposal
https://bugs.webkit.org/show_bug.cgi?id=191677

Attachment 355194: Patch

https://bugs.webkit.org/attachment.cgi?id=355194&action=review




--- Comment #36 from Darin Adler <darin at apple.com> ---
Comment on attachment 355194
  --> https://bugs.webkit.org/attachment.cgi?id=355194
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355194&action=review

> Source/WTF/wtf/text/StringBuilderJSON.cpp:84
> +	   if (U16_IS_SURROGATE_TRAIL(character) || next == end ||
!U16_IS_SURROGATE_TRAIL(*next)) {

Oops, this is wrong! Details to come.


More information about the webkit-reviews mailing list