[webkit-reviews] review granted: [Bug 191677] [JSC] Implement "well-formed JSON.stringify" proposal : [Attachment 355194] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 191677: [JSC] Implement "well-formed JSON.stringify" proposal
https://bugs.webkit.org/show_bug.cgi?id=191677

Attachment 355194: Patch

https://bugs.webkit.org/attachment.cgi?id=355194&action=review




--- Comment #35 from Darin Adler <darin at apple.com> ---
Comment on attachment 355194
  --> https://bugs.webkit.org/attachment.cgi?id=355194
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355194&action=review

> Source/WTF/wtf/text/StringBuilderJSON.cpp:85
> +	       uint8_t upper = static_cast<uint32_t>(character) >> 8;

I don’t understand what value the static_cast<uint32_t> has here. It seems the
code would do the right thing without that.

> Source/WTF/wtf/text/StringBuilderJSON.cpp:86
> +	       uint8_t lower = static_cast<uint8_t>(character);

I don’t understand what value the static_cast<uint8_t> has here. It seems the
code would do the right thing without that.