[webkit-reviews] review granted: [Bug 192427] Stop defining CGFloat in WebKit : [Attachment 356747] ...and include CoreGraphics.h

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 192427: Stop defining CGFloat in WebKit
https://bugs.webkit.org/show_bug.cgi?id=192427

Attachment 356747: ...and include CoreGraphics.h

https://bugs.webkit.org/attachment.cgi?id=356747&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 356747
  --> https://bugs.webkit.org/attachment.cgi?id=356747
...and include CoreGraphics.h

View in context: https://bugs.webkit.org/attachment.cgi?id=356747&action=review

> Source/WebCore/WebCorePrefix.h:90
> +#include <CoreGraphics/CoreGraphics.h>

Why did you remove all the CG headers?

"The project should be able to build without this header, although we rarely
test that."

> Source/WebKitLegacy/mac/ChangeLog:18
> +2018-12-05  Alexey Proskuryakov  <ap at apple.com>
> +
> +	   Stop defining CGFloat in WebKit
> +	   https://bugs.webkit.org/show_bug.cgi?id=192427
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * WebKitPrefix.h:

Double changelog