[webkit-reviews] review granted: [Bug 192426] Move USE_NEW_THEME out of WebCore's config.h : [Attachment 356655] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 6 13:51:11 PST 2018

Tim Horton <thorton at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 192426: Move USE_NEW_THEME out of WebCore's config.h

Attachment 356655: proposed patch


--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 356655
  --> https://bugs.webkit.org/attachment.cgi?id=356655
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356655&action=review

> Source/WTF/wtf/Platform.h:1427
> +/* FIXME: This really needs a descriptive name, this "new theme" was added
in 2008. */

Agreed! And the refactor wasn't even completed, so this is really a bit of a

More information about the webkit-reviews mailing list