[webkit-reviews] review granted: [Bug 188768] CSE DataViewGet* DFG nodes : [Attachment 348441] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 30 11:55:39 PDT 2018


Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 188768: CSE DataViewGet* DFG nodes
https://bugs.webkit.org/show_bug.cgi?id=188768

Attachment 348441: patch

https://bugs.webkit.org/attachment.cgi?id=348441&action=review




--- Comment #4 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 348441
  --> https://bugs.webkit.org/attachment.cgi?id=348441
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348441&action=review

r=me

> Source/JavaScriptCore/dfg/DFGHeapLocation.h:-118
> -	   return m_kind + m_heap.hash() + m_index.hash() + m_kind;

Nice!


More information about the webkit-reviews mailing list