[webkit-reviews] review granted: [Bug 182891] [CMake] Replace AVFoundationSupport.py using CMake : [Attachment 348359] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 30 11:35:54 PDT 2018
Per Arne Vollan <pvollan at apple.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 182891: [CMake] Replace AVFoundationSupport.py using CMake
https://bugs.webkit.org/show_bug.cgi?id=182891
Attachment 348359: Patch
https://bugs.webkit.org/attachment.cgi?id=348359&action=review
--- Comment #29 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 348359
--> https://bugs.webkit.org/attachment.cgi?id=348359
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=348359&action=review
r=me. Please make sure the bots are green before landing.
> Source/WebCore/PAL/ChangeLog:8
> + Remove AVFoundationSupport.py file and invokation.
invocation
> Source/WebKitLegacy/win/WebKitPrefix.h:69
> +#if USE(CG)
> +#ifndef CGFLOAT_DEFINED
> +#if (defined(__LP64__) && __LP64__) || (defined(__x86_64__) && __x86_64__)
|| defined(_M_X64) || defined(__amd64__)
> +typedef double CGFloat;
> +#else
> +typedef float CGFloat;
> +#endif
> +#define CGFLOAT_DEFINED 1
> +#endif
> +#endif /* USE(CG) */
This could perhaps be put in a new header file (CGFloat.h) to avoid
duplication.
> Source/cmake/WebKitCommon.cmake:-78
> - file(MAKE_DIRECTORY ${DERIVED_SOURCES_PAL_DIR})
Is creating this directory not needed anymore?
More information about the webkit-reviews
mailing list