[webkit-reviews] review granted: [Bug 189141] [LFC][Margins] Add non-computed horizontal margins to DisplayBox : [Attachment 348482] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 30 06:42:54 PDT 2018
Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 189141: [LFC][Margins] Add non-computed horizontal margins to DisplayBox
https://bugs.webkit.org/show_bug.cgi?id=189141
Attachment 348482: Patch
https://bugs.webkit.org/attachment.cgi?id=348482&action=review
--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 348482
--> https://bugs.webkit.org/attachment.cgi?id=348482
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=348482&action=review
> Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:241
> + return WidthAndMargin { *width, { *marginLeft, *marginRight }, {
nonComputedMarginLeft, nonComputedMarginRight } };
return { *width, { *marginLeft, *marginRight }, { nonComputedMarginLeft,
nonComputedMarginRight } } ;
should work too?
More information about the webkit-reviews
mailing list