[webkit-reviews] review granted: [Bug 189149] [ConnectionUnix] Shrink sizeof AttachmentInfo by reordering members : [Attachment 348489] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Yoshiaki Jitsukawa
<yoshiaki.jitsukawa at sony.com>'s request for review:
Bug 189149: [ConnectionUnix] Shrink sizeof AttachmentInfo by reordering members
https://bugs.webkit.org/show_bug.cgi?id=189149

Attachment 348489: Patch

https://bugs.webkit.org/attachment.cgi?id=348489&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 348489
  --> https://bugs.webkit.org/attachment.cgi?id=348489
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348489&action=review

> Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:93
> +static_assert(sizeof(MessageInfo) + sizeof(AttachmentInfo) *
attachmentMaxAmount <= messageMaxSize, "messageMaxSize is too small.");

Oh wow, good catch