[webkit-reviews] review granted: [Bug 188646] [GStreamer][MSE] Remove parsers from playback pipeline : [Attachment 347257] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 188646: [GStreamer][MSE] Remove parsers from playback pipeline
https://bugs.webkit.org/show_bug.cgi?id=188646

Attachment 347257: Patch

https://bugs.webkit.org/attachment.cgi?id=347257&action=review




--- Comment #4 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 347257
  --> https://bugs.webkit.org/attachment.cgi?id=347257
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347257&action=review

I would like Enrique or Alicia to comment on this before landing (after fixing
the comments)

> Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:178
>      const char* mediaType = capsMediaType(caps);
>      GST_DEBUG_OBJECT(webKitMediaSrc, "Configured track %s: appsrc=%s,
padId=%u, mediaType=%s", trackPrivate->id().string().utf8().data(),
GST_ELEMENT_NAME(stream->appsrc), padId, mediaType);

mediaType would be now used nowhere else, so variable can be removed and result
passed directly to GST_DEBUG_OBJECT.

>
Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:4
96
>      if (!caps || !stream->parent) {

We need to fix the GST_ERROR bellow this line or it would be misleading :)