[webkit-reviews] review granted: [Bug 188653] [GStreamer] Warn early about incomplete MSE track switching support : [Attachment 347264] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 17 01:24:16 PDT 2018


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 188653: [GStreamer] Warn early about incomplete MSE track switching support
https://bugs.webkit.org/show_bug.cgi?id=188653

Attachment 347264: Patch

https://bugs.webkit.org/attachment.cgi?id=347264&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 347264
  --> https://bugs.webkit.org/attachment.cgi?id=347264
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347264&action=review

Let's also wait for Enrique or Alicia to comment on this before landing.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:723
> +    // FIXME: Remove isMediaSource() test below when fixing
https://bugs.webkit.org/show_bug.cgi?id=182531

Nit: . at the end.


More information about the webkit-reviews mailing list