[webkit-reviews] review granted: [Bug 188609] [Curl] Implement default cookie path handling correctly as outlined in RFC6265. : [Attachment 347196] PATCH

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188609: [Curl] Implement default cookie path handling correctly as outlined
in RFC6265.
https://bugs.webkit.org/show_bug.cgi?id=188609

Attachment 347196: PATCH

https://bugs.webkit.org/attachment.cgi?id=347196&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 347196
  --> https://bugs.webkit.org/attachment.cgi?id=347196
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=347196&action=review

>>> Source/WebCore/platform/network/curl/CookieUtil.cpp:189
>>> +	 if (!lastSlashPosition)
>> 
>> notFound
> 
> I think this confusion is from the style checker complaining about comparison
with 0 and !lastSlashPosition was done to make it happy.
> We do actually want to check if the lastSlashPosition is 0 so '/path' returns
'/' instead of empty string. We also know that there is always at least one
slash in the path string from the condition above.
> 
> I think it should be changed to lastSlashPosition == 0 ignoring the style
checker.

If path is null, reverseFind returns notFound.	We already have a check for
that above, so no problem here.