[webkit-reviews] review granted: [Bug 188571] [YARR] Align allocation size in BumpPointerAllocator with sizeof(void*) : [Attachment 347100] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 188571: [YARR] Align allocation size in BumpPointerAllocator with
sizeof(void*)
https://bugs.webkit.org/show_bug.cgi?id=188571

Attachment 347100: Patch

https://bugs.webkit.org/attachment.cgi?id=347100&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 347100
  --> https://bugs.webkit.org/attachment.cgi?id=347100
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347100&action=review

> Source/JavaScriptCore/yarr/YarrInterpreter.cpp:77
> +	   static size_t allocationSize(size_t numberOfFrames)

Should we be worried about overflow here?

> Source/JavaScriptCore/yarr/YarrInterpreter.cpp:133
> +	   static size_t allocationSize(size_t numberOfSubpatterns)

Ditto