[webkit-reviews] review granted: [Bug 188260] Text selection color is hard to see in dark mode web views : [Attachment 346389] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 188260: Text selection color is hard to see in dark mode web views
https://bugs.webkit.org/show_bug.cgi?id=188260

Attachment 346389: Patch

https://bugs.webkit.org/attachment.cgi?id=346389&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 346389
  --> https://bugs.webkit.org/attachment.cgi?id=346389
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346389&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:345
> +	   return !color.isOpaque() ? color : color.colorWithAlpha(0.8);

Would be nicer to say where the 0.8 comes from.

> Source/WebCore/rendering/RenderThemeMac.mm:784
> +		   return Color(0xCC3F638B, Color::Semantic);

Would prefer to see use the Color(int, int, int) constructor.