[webkit-reviews] review granted: [Bug 188133] Check with SafeBrowsing during navigation in WKWebView : [Attachment 346388] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188133: Check with SafeBrowsing during navigation in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=188133

Attachment 346388: Patch

https://bugs.webkit.org/attachment.cgi?id=346388&action=review




--- Comment #11 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 346388
  --> https://bugs.webkit.org/attachment.cgi?id=346388
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346388&action=review

r=me with suggestion.

> Source/WebKit/UIProcess/WebPageProxy.cpp:4152
> +    listener->didReceiveSafeBrowsingResults({ });

This looks hackish/fragile. Is this temporary? I think I'd much prefer we pass
a ShouldExpectSafeBrowsingResult { No, Yes } parameter.

> Source/WebKit/UIProcess/WebPageProxy.cpp:4189
> +    listener->didReceiveSafeBrowsingResults({ });

ditto.