[webkit-reviews] review granted: [Bug 184807] Add a test to verify load/unload/pageshow/pagehide all work with process swapping : [Attachment 338427] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 20 09:03:34 PDT 2018


Chris Dumez <cdumez at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 184807: Add a test to verify load/unload/pageshow/pagehide all work with
process swapping
https://bugs.webkit.org/show_bug.cgi?id=184807

Attachment 338427: patch

https://bugs.webkit.org/attachment.cgi?id=338427&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 338427
  --> https://bugs.webkit.org/attachment.cgi?id=338427
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338427&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:946
> +// Disabling the page cache explicitly is (for some reason) not availabe on
iOS

typo: availabe

Also should end with a period.


More information about the webkit-reviews mailing list