[webkit-reviews] review granted: [Bug 184421] Make PluginData cache its web visible plugins : [Attachment 337549] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 184421: Make PluginData cache its web visible plugins
https://bugs.webkit.org/show_bug.cgi?id=184421

Attachment 337549: Patch

https://bugs.webkit.org/attachment.cgi?id=337549&action=review




--- Comment #14 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 337549
  --> https://bugs.webkit.org/attachment.cgi?id=337549
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337549&action=review

r=me with comment.

> Source/WebCore/plugins/PluginData.h:131
> +    mutable URL m_pageURL;

The naming here is a bit too generic. We should convey that this relates to the
m_visiblePlugins cache member below. I would suggest:
- m_cachedVisiblePluginsURL
- m_cachedVisiblePlugins

Or similar.

Alternatively, we could merge them into a single data member:
mutable std::optional<std::pair<URL, Vector<PluginInfo>>>
m_cachedVisiblePlugins;