[webkit-reviews] review requested: [Bug 183060] [Curl][WinCairo] WinCairo should use a Public Suffix List to prevent cookies from being set for TLDs : [Attachment 338381] Updated patch

[bugzilla-daemon at webkit.org]

Christopher Reid <chris.reid at sony.com> has asked  for review:
Bug 183060: [Curl][WinCairo] WinCairo should use a Public Suffix List to
prevent cookies from being set for TLDs
https://bugs.webkit.org/show_bug.cgi?id=183060

Attachment 338381: Updated patch

https://bugs.webkit.org/attachment.cgi?id=338381&action=review




--- Comment #12 from Christopher Reid <chris.reid at sony.com> ---
Created attachment 338381

  --> https://bugs.webkit.org/attachment.cgi?id=338381&action=review

Updated patch

I ended up keeping a return of UCharBuffer instead of an LCharBuffer as there
was a case where hostnames over 2048 characters won't get encoded to punycode.

I also tried to modernize chromium's lookup code a bit. The dafsa data is now
using a static NeverDestroyed vector instead of a raw array.

Also this is a bit out of scope from these changes but one thing I noticed is
that URL.cpp is still using the deprecated uidna_IDNToASCII for encoding
hostnames. Is there a reason it wasn't updated to use IDN2008 yet? I tried it
out in trunk and setting window.location.host or window.location.href to a
hostname containing ß can resolve to different domains.