[webkit-reviews] review granted: [Bug 184793] Make back forward cache work with process swapping : [Attachment 338359] patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 184793: Make back forward cache work with process swapping
https://bugs.webkit.org/show_bug.cgi?id=184793

Attachment 338359: patch

https://bugs.webkit.org/attachment.cgi?id=338359&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 338359
  --> https://bugs.webkit.org/attachment.cgi?id=338359
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338359&action=review

r=me

> Source/WebKit/UIProcess/WebBackForwardList.h:77
> +    Vector<BackForwardListItemState>
filteredItems(Function<bool(WebBackForwardListItem&)>&&) const;

filteredItems is not very consistent with itemStates above. I would suggest
filteredItemStates for consistency.