[webkit-reviews] review granted: [Bug 184723] Allow SameOrigin credentials handling for synchronous XHR : [Attachment 338195] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 184723: Allow SameOrigin credentials handling for synchronous XHR
https://bugs.webkit.org/show_bug.cgi?id=184723

Attachment 338195: Patch

https://bugs.webkit.org/attachment.cgi?id=338195&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 338195
  --> https://bugs.webkit.org/attachment.cgi?id=338195
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338195&action=review

>>> Source/WebKit/NetworkProcess/NetworkResourceLoader.h:134
>>> +	 void startNetworkLoad(WebCore::ResourceRequest&&, FirstLoad =
FirstLoad::Yes);
>> 
>> I'd prefer to not have a default parameter so we don't accidentally omit the
parameter when writing redirection code.
> 
> There are 6 calls to startNetworkLoad so I would tend to prefer keeping it,
but I can make the change.
> If we are not using the right parameter, there will be crashes anyway since
we are consuming sandbox extensions.

I'd still prefer to add explicit calls.