[webkit-reviews] review granted: [Bug 184753] Detect system preview links : [Attachment 338260] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 184753: Detect system preview links
https://bugs.webkit.org/show_bug.cgi?id=184753

Attachment 338260: Patch

https://bugs.webkit.org/attachment.cgi?id=338260&action=review




--- Comment #4 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 338260
  --> https://bugs.webkit.org/attachment.cgi?id=338260
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338260&action=review

> Source/WebCore/html/HTMLAnchorElement.cpp:388
> +	       return (numChildren == 1 || numChildren == 2);

Don't need the parentheses.

> Source/WebCore/testing/Internals.cpp:4494
> +    return downcast<HTMLAnchorElement>(element).isSystemPreviewLink();

return is<HTMLAnchorElement>(element) &&
downcast<HTMLAnchorElement>(element).isSystemPreviewLink();

> LayoutTests/system-preview/detection.html:12
> +	   children = link.children;

Single-clause if statement should not use curly braces.

> LayoutTests/system-preview/detection.html:25
> +window.addEventListener("load", function () {

() =>

> LayoutTests/system-preview/detection.html:44
> +	       addResult(result, "No link.");

Single-clause else statement should not use curly braces.