[webkit-reviews] review granted: [Bug 184524] [WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit : [Attachment 337769] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 184524: [WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit
https://bugs.webkit.org/show_bug.cgi?id=184524

Attachment 337769: Patch

https://bugs.webkit.org/attachment.cgi?id=337769&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 337769
  --> https://bugs.webkit.org/attachment.cgi?id=337769
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337769&action=review

> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:38
> +    constexpr size_t bufferLength = _MAX_PATH * 4;

This seems excessive.

> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:53
> +    String filename =
String::format("..\\..\\..\\Tools\\TestWebKitAPI\\Tests\\WebKit\\%s.%s",
resource, extension);

This seems specific to a certain build configuration.