[webkit-reviews] review denied: [Bug 182869] [WinCairo] Add WKView and WKAPI : [Attachment 337690] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 182869: [WinCairo] Add WKView and WKAPI
https://bugs.webkit.org/show_bug.cgi?id=182869

Attachment 337690: Patch

https://bugs.webkit.org/attachment.cgi?id=337690&action=review




--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 337690
  --> https://bugs.webkit.org/attachment.cgi?id=337690
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337690&action=review

> Source/WebKit/UIProcess/Launcher/win/ProcessLauncherWin.cpp:35
> +const LPCWSTR webKitDLLName = L"WebKit2.dll";

Do we want this name?

> Source/WebKit/UIProcess/win/WebContextMenuProxyWin.h:51
> +    WebPageProxy* m_page;

It looks like this could be a WebPageProxy&.

> Source/WebKit/UIProcess/win/WebView.cpp:72
> +SOFT_LINK_LIBRARY(IMM32)

Why are we soft linking instead of directly linking?

> Source/WebKit/UIProcess/win/WebView.cpp:245
> +    , m_toolTipWindow(0)

These should be { nullptr } in the header.

> Source/WebKit/UIProcess/win/WebView.h:57
> +    static WebView* create(RECT rect, const API::PageConfiguration&
configuration, HWND parentWindow)

This should return a std::unique_ptr or UniqueRef.