[webkit-reviews] review granted: [Bug 177206] Web Inspector: Include a table in New Network Tab : [Attachment 321611] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 177206: Web Inspector: Include a table in New Network Tab
https://bugs.webkit.org/show_bug.cgi?id=177206

Attachment 321611: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=321611&action=review




--- Comment #10 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 321611
  --> https://bugs.webkit.org/attachment.cgi?id=321611
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=321611&action=review

r=me

> Source/WebInspectorUI/ChangeLog:30
> +	   the sub-content browser.

Forwarding shown and hidden to subviews will no longer be necessary once
<https://webkit.org/b/150741> is completed. Some ContentViews that perform
forwarding have FIXMEs, but these spots are easy enough to find so it's up to
you.

> Source/WebInspectorUI/ChangeLog:183
> +	   (WI.NetworkTableContentView.prototype._updateCellsForResource):

Changelog needs to be re-generated. `_updateCellsForResource` was renamed
`_updateEntryForResource`.

> Source/WebInspectorUI/ChangeLog:200
> +	   The NetworkTableContentView has a Table and it is data source and

The NetworkTableContentView has a Table and is a data source and delegate.

> Source/WebInspectorUI/UserInterface/Views/Table.js:55
> +	   this._scrollContainerElement =
this._element.appendChild(document.createElement("div"));

Should be `this.element`, otherwise we're reading the private variable from the
base class.