[webkit-reviews] review granted: [Bug 177304] WebDriver: Add support to import and run W3C tests : [Attachment 321564] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 177304: WebDriver: Add support to import and run W3C tests
https://bugs.webkit.org/show_bug.cgi?id=177304

Attachment 321564: Patch

https://bugs.webkit.org/attachment.cgi?id=321564&action=review




--- Comment #8 from Brian Burg <bburg at apple.com> ---
Comment on attachment 321564
  --> https://bugs.webkit.org/attachment.cgi?id=321564
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321564&action=review

r=me

> Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:48
> +	   if self._port.host.platform.is_mac():

Shouldn't this use mkdtemp or similar? Why is Mac a special case?