[webkit-reviews] review denied: [Bug 177071] [WK1] Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing. : [Attachment 321101] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 177071: [WK1] Layout Test
fast/events/beforeunload-dom-manipulation-crash.html is crashing.
https://bugs.webkit.org/show_bug.cgi?id=177071

Attachment 321101: Patch

https://bugs.webkit.org/attachment.cgi?id=321101&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 321101
  --> https://bugs.webkit.org/attachment.cgi?id=321101
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321101&action=review

Thank you for fixing this. Please make the two adjustments I requested so we
have a complete fix.

> Source/WebCore/ChangeLog:9
> +	   accessing the page. 

Thank you! I have an partial patch for this that touches one or two other
things. Let me annotate your patch.

Can you please make the same fix in
"HistoryController::updateForSameDocumentNavigation". In that method, it checks
the page for "usesEphemeralSession" before it checks for a nullptr page. THEN
it checks for nullptr!

In the same vein, can you please move the ASSERT(m_frame.page()) in
"HistoryController::replaceState" so that it is called before the dereference
of page to call 'usesEphemeralSession'?