[webkit-reviews] review denied: [Bug 176962] webkitpy: Provide accessor for device type : [Attachment 320836] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 176962: webkitpy: Provide accessor for device type
https://bugs.webkit.org/show_bug.cgi?id=176962

Attachment 320836: Patch

https://bugs.webkit.org/attachment.cgi?id=320836&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 320836
  --> https://bugs.webkit.org/attachment.cgi?id=320836
Patch

This patch assumes the convention that the name of the simulator will contain
the name of the device. This is a convention. The name of a simulator device is
arbitrary; => we should not parse the device name to determine the device type
it corresponds to. Moreover, we do not have to resort to such manipulation. The
command "simctl list" prints the list of device types under the "== Device
Types ==" section and the parsing code in simulator.py knows how to parse this
section. We need to teach the parsing code to pass the human readable name
corresponding to the device type when instantiating a SimulatedDevice object.