[webkit-reviews] review canceled: [Bug 176884] WebContentReader::readWebArchive doesn't need to handle image MIME type : [Attachment 320722] Added missing includes

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 176884: WebContentReader::readWebArchive doesn't need to handle image MIME
type
https://bugs.webkit.org/show_bug.cgi?id=176884

Attachment 320722: Added missing includes

https://bugs.webkit.org/attachment.cgi?id=320722&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 320722
  --> https://bugs.webkit.org/attachment.cgi?id=320722
Added missing includes

View in context: https://bugs.webkit.org/attachment.cgi?id=320722&action=review

>> Source/WebCore/editing/WebContentReader.h:55
>>  #endif
> 
> I still think this could be available to all platforms. There really isn't
anything cocoa specific about it.

Yeah, let's just do that.

>> Source/WebCore/editing/WebContentReader.h:59
>>	bool readWebArchive(SharedBuffer*) override;
> 
> Perhaps this should be in a #if ENABLE(LEGACY_WEB_ARCHIVE).

Perhaps. I think Darin's intention was implementing these functions on all
platforms.
I'm gonna leave them alone for now.