[webkit-reviews] review granted: [Bug 176800] [Cleanup] Cleanup uses of the FileList class : [Attachment 320568] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 176800: [Cleanup] Cleanup uses of the FileList class
https://bugs.webkit.org/show_bug.cgi?id=176800

Attachment 320568: Patch

https://bugs.webkit.org/attachment.cgi?id=320568&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 320568
  --> https://bugs.webkit.org/attachment.cgi?id=320568
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320568&action=review

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:2700
>		   if (!readFile(file))
>		       return JSValue();
>		   if (m_isDOMGlobalObject)
> -		       files.append(WTFMove(file));
> +		       files.append(file.releaseNonNull());

This would be nicer if you made readFile take no parameters and return a
RefPtr.