[webkit-reviews] review granted: [Bug 149703] [GTK] DOM operations could behave unexpectedly with certain fonts or font sizes : [Attachment 320250] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Tomas Popela
<tpopela at redhat.com>'s request for review:
Bug 149703: [GTK] DOM operations could behave unexpectedly with certain fonts
or font sizes
https://bugs.webkit.org/show_bug.cgi?id=149703

Attachment 320250: Patch

https://bugs.webkit.org/attachment.cgi?id=320250&action=review




--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 320250
  --> https://bugs.webkit.org/attachment.cgi?id=320250
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320250&action=review

It's not often that people contribute regression tests except when trying to
get a functional change into WebKit. Thanks! Also good to see the test passes
the Apple EWS bots on the first try.

>
LayoutTests/fast/dom/Document/CaretRangeFromPoint/restore-selection-from-point.
html:56
> +    <div style="width: 72ch; word-wrap: normal;" >12</div>
> +    <div style="width: 72ch; word-wrap: normal;" >34<span
id="selection-start"></span><span id="selection-end"></span></div>

The 12 and 34 are arbitrary, right? That's a bit confusing.