[webkit-reviews] review granted: [Bug 176345] [DFG] PutByVal with Array::Generic is too generic : [Attachment 320257] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 8 11:26:02 PDT 2017


Filip Pizlo <fpizlo at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 176345: [DFG] PutByVal with Array::Generic is too generic
https://bugs.webkit.org/show_bug.cgi?id=176345

Attachment 320257: Patch

https://bugs.webkit.org/attachment.cgi?id=320257&action=review




--- Comment #5 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 320257
  --> https://bugs.webkit.org/attachment.cgi?id=320257
Patch

Cool!

I think that we can make the Generic case even better by implementing it as an
inline cache.  Then we can have baseline, DFG, and FTL share that inline cache.
 And we could use it for better array access profiling.


More information about the webkit-reviews mailing list