[webkit-reviews] review granted: [Bug 176435] Add support for RegExp named capture groups : [Attachment 320067] Updated patch addressing review comments and test failures.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 7 12:54:52 PDT 2017
Filip Pizlo <fpizlo at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 176435: Add support for RegExp named capture groups
https://bugs.webkit.org/show_bug.cgi?id=176435
Attachment 320067: Updated patch addressing review comments and test failures.
https://bugs.webkit.org/attachment.cgi?id=320067&action=review
--- Comment #19 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 320067
--> https://bugs.webkit.org/attachment.cgi?id=320067
Updated patch addressing review comments and test failures.
View in context: https://bugs.webkit.org/attachment.cgi?id=320067&action=review
> Source/JavaScriptCore/runtime/RegExpMatchesArray.h:107
> -
> +
Revert
> Source/JavaScriptCore/runtime/RegExpMatchesArray.h:130
> -
> +
Revert
More information about the webkit-reviews
mailing list