[webkit-reviews] review granted: [Bug 176435] Add support for RegExp named capture groups : [Attachment 320067] Updated patch addressing review comments and test failures.

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 176435: Add support for RegExp named capture groups
https://bugs.webkit.org/show_bug.cgi?id=176435

Attachment 320067: Updated patch addressing review comments and test failures.

https://bugs.webkit.org/attachment.cgi?id=320067&action=review




--- Comment #17 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 320067
  --> https://bugs.webkit.org/attachment.cgi?id=320067
Updated patch addressing review comments and test failures.

View in context: https://bugs.webkit.org/attachment.cgi?id=320067&action=review

r=me though it would be good if someone else took a look too since I'm not
familiar with the code.

> Source/JavaScriptCore/runtime/RegExpMatchesArray.cpp:74
> +enum class ShouldCreateGroups { DontCreateGroups, CreateGroups };

With enum class I wouldn't repeat "Group" in the enumerated names. Maybe even
just ShouldCreateGroup::{No,Yes} ?