[webkit-reviews] review denied: [Bug 176381] [Win] Compile errors in Document::updateTitleElement. : [Attachment 319916] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 6 09:36:50 PDT 2017
Darin Adler <darin at apple.com> has denied Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 176381: [Win] Compile errors in Document::updateTitleElement.
https://bugs.webkit.org/show_bug.cgi?id=176381
Attachment 319916: Patch
https://bugs.webkit.org/attachment.cgi?id=319916&action=review
--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 319916
--> https://bugs.webkit.org/attachment.cgi?id=319916
Patch
A better way to work around this unfortunate limitation of the Windows compiler
it is to convert all 6 of the lambdas into plain old functions, outside
Document::updateTitleElement, just local functions like:
static Element* findHTMLTitle(Document& document)
{
}
More information about the webkit-reviews
mailing list