[webkit-reviews] review granted: [Bug 176331] [JSC] Remove "malloc" and "free" from JSC/API : [Attachment 320025] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 6 09:31:05 PDT 2017


Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 176331: [JSC] Remove "malloc" and "free" from JSC/API
https://bugs.webkit.org/show_bug.cgi?id=176331

Attachment 320025: Patch

https://bugs.webkit.org/attachment.cgi?id=320025&action=review




--- Comment #9 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 320025
  --> https://bugs.webkit.org/attachment.cgi?id=320025
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320025&action=review

r=me. This is a nice cleanup patch!

> Source/JavaScriptCore/API/JSWrapperMap.mm:278
> +		   property.getterName = @(attributes[i].value);

Wow, I didn't know there was a magic @ operator in Obj-C. Learn something new
everyday!


More information about the webkit-reviews mailing list