[webkit-reviews] review granted: [Bug 176033] Web Inspector: Styles Redesign: display "Inherited From" section headers : [Attachment 319957] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <webkit at devinrousso.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 176033: Web Inspector: Styles Redesign: display "Inherited From" section
headers
https://bugs.webkit.org/show_bug.cgi?id=176033

Attachment 319957: Patch

https://bugs.webkit.org/attachment.cgi?id=319957&action=review




--- Comment #6 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 319957
  --> https://bugs.webkit.org/attachment.cgi?id=319957
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319957&action=review

r=me

>
Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
53
> +    static createInheritedHeader(style)

Is there a reason for this to be public static?

>
Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
108
> +		   let inheritedHeader =
WI.SpreadsheetRulesStyleDetailsPanel.createInheritedHeader(style);
> +		   this.element.append(inheritedHeader);

I don't think this needs to be in it's own variable, especially if you drop the
static:

    this.element.appendChild(this._createInheritedHeader(style));

or even better, you could just do the append inside the function and name it
something like `_appendInheritedHeader` :)