[webkit-reviews] review denied: [Bug 139438] [CMake] Enable pre-compiled headers (PCH) : [Attachment 319716] WIP, fixes WebCoreDerivedSourcesPrefix; the style checker will still fail.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 5 18:05:12 PDT 2017


Michael Catanzaro <mcatanzaro at igalia.com> has denied Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 139438: [CMake] Enable pre-compiled headers (PCH)
https://bugs.webkit.org/show_bug.cgi?id=139438

Attachment 319716: WIP, fixes WebCoreDerivedSourcesPrefix; the style checker
will still fail.

https://bugs.webkit.org/attachment.cgi?id=319716&action=review




--- Comment #26 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 319716
  --> https://bugs.webkit.org/attachment.cgi?id=319716
WIP, fixes WebCoreDerivedSourcesPrefix; the style checker will still fail.

I don't see anything major wrong with this, but you have some comments to
address so let's get this out of the request queue for now.


More information about the webkit-reviews mailing list