[webkit-reviews] review granted: [Bug 176241] Do not Reject CacheStorage promises when updating the persistent filesystem data fails : [Attachment 319635] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 1 15:00:33 PDT 2017


Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 176241: Do not Reject CacheStorage promises when updating the persistent
filesystem data fails
https://bugs.webkit.org/show_bug.cgi?id=176241

Attachment 319635: Patch

https://bugs.webkit.org/attachment.cgi?id=319635&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 319635
  --> https://bugs.webkit.org/attachment.cgi?id=319635
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319635&action=review

> Source/WebCore/Modules/cache/DOMCacheEngine.h:88
> +    template<class Decoder> static bool decode(Decoder&,
CacheIdentifierOperationResult&);

This could return a std::optional<CacheIdentifierOperationResult>


More information about the webkit-reviews mailing list