[webkit-reviews] review granted: [Bug 176202] Allow retrieving Cache Storage records for a given URL only : [Attachment 319610] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 176202: Allow retrieving Cache Storage records for a given URL only
https://bugs.webkit.org/show_bug.cgi?id=176202

Attachment 319610: Patch

https://bugs.webkit.org/attachment.cgi?id=319610&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 319610
  --> https://bugs.webkit.org/attachment.cgi?id=319610
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319610&action=review

> Source/WebCore/Modules/cache/Cache.cpp:388
> +    retrieveURL.setQuery({ });

Do we want to remove the fragment here, too?

> Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.cpp:104
> +    if (keyURL.hasQuery())
> +	   keyURL.setQuery({ });
> +    keyURL.removeFragmentIdentifier();

Maybe we should make a method to do both of these at the same time.  That would
avoid an unnecessary string allocation and copy.

> Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.cpp:116
> +    Vector<Record> newRecords;
> +    newRecords.reserveInitialCapacity(1);
> +    newRecords.uncheckedAppend(WTFMove(record));
> +    return m_records.set(key, WTFMove(newRecords)).iterator->value.last();

{ WTFMove(record) }